BUG: Fix Series.str.contains with compiled regex on Arrow strings (#61942) #61945
+29
−1,486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dex with check_categorical=True and exact=False
That was previous changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#61942
This PR improves the handling of this case:
If the compiled regex has no flags, we extract the pattern string and proceed.
If the regex includes flags, a clear NotImplementedError is raised with guidance.
This avoids a confusing low-level PyArrow TypeError and ensures consistent behavior with non-Arrow strings.
Please , suggest feedback if my approach is not correct . I would love to improve and fix this.