docs: Improve README with helpful contributor resources #61953
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 12, 2025 20:30
### Summary This commit updates `doc/source/development/index.rst` to include a reference to the newly added `code_guidelines.md` document. The goal is to make the unified coding guideline document visible in the Pandas developer documentation sidebar. ### Why This Matters - Previously, `code_guidelines.md` was added under `doc/source/development/` to address Issue #33851. - Without referencing it in `index.rst`, the file would not appear in the built documentation. - This change ensures the document is accessible to all contributors via the official Pandas documentation site. ### What Changed - Added `code_guidelines` to the existing `.. toctree::` directive. - Positioned it below `contributing_codebase` as it logically relates to coding standards. ### Follow-Up This completes the documentation improvement proposed in #33851. All checks have passed, and the document is now correctly linked in the navigation structure.
This commit addresses a bug (issue #61841) in the pandas .rolling().mean() method, where reassigning the result of a rolling mean computation on the same column leads to unexpected NaN values. The root cause was incorrect alignment and slicing when using the step parameter inside the Window._apply() method. The fix ensures the result is properly computed and sliced only after the entire output is generated. Additionally, this update cleans up inconsistent import usage by moving Series and DataFrame imports to the top-level, which resolves pre-commit CI errors. After this fix, repeated assignments using .rolling().mean() behave as expected, and all pre-commit checks pass successfully.
BUG: Fix .rolling().mean() reassignment returning NaNs (pandas-dev#
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a small section to the end of the README that provides useful resources for new contributors, including:
This addition aims to encourage and guide new contributors without altering any of the existing README content.
Let me know if this fits the community guidelines — happy to adjust!