BUG: Fix is_signed_integer_dtype to handle abstract floating types (GH 62018) #62020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…H 62018) and add unit test
…H 62018) and add unit test
|
Please wait for discussion on the issue as to whether this is worth doing. |
|
Hi @jbrockmendel, just following up, if there are any updates on #62018? Happy to adjust the PR based on the discussion. |
|
Per my comment on the issue, i dont think anything should be done here. can wait to see if other maintainers have other opinions. |
|
Going to close this PR until more folks weight in on the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(#GH 62018)
This PR fixes a bug in (is_signed_integer_dtype) where abstarct Numpy floating types would raise a TypeError .
Now, the function returns False for these types, as expected.
Please let me know if my approach or fix needs any improvements . I’m open to feedback and happy to make changes based on suggestions.
Thankyou !