BUG: Catch TypeError in _is_dtype_type when converting abstract numpy types (#62018) #62030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#61781) Replace reference to ``other`` with ``self`` in the generic mask/where docstring template so that the note correctly explains that misaligned index positions are filled based on alignment between `self` and `cond`, not `other` and `cond`. Fixes GH#61781.
DOC: Fix mask/where docstring to align with self and cond (pandas-dev#61781)
… type (pandas-dev#62018) Wrap np.dtype() call in try/except to handle abstract numpy types like np.floating and return condition(type(None)) on TypeError.
|
This is a small perf hit that will add up in a ton of places, all for something that we shouldn't expect to work anyway. |
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents
is_signed_integer_dtypeand similar functions from raising on abstract NumPy classes and restores expected behaviour.