-
-
Notifications
You must be signed in to change notification settings - Fork 19.1k
BUG: Fix all-NaT when ArrowEA.astype to categorical #62055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arthurlw
wants to merge
13
commits into
pandas-dev:main
Choose a base branch
from
arthurlw:arrowEA_categorical_returning_NaT
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+41
−2
Open
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
58284dd
Added condition for CategoricalDtype
arthurlw 1896199
Added tests
arthurlw 36b84cf
whatsnew
arthurlw 2dc0698
Added GH ref
arthurlw 5987952
Updated conditions
arthurlw a5fab10
Updated fix logic
arthurlw e6b7c64
importorskip
arthurlw 95e331c
Update fix logic
arthurlw 3453487
precommit and removed unnecessary comments
arthurlw d747141
Update condition
arthurlw d6a5a50
moved condition to maybe helper and added maybe downcast before compa…
arthurlw 0f43eca
Updated tests with intermediate steps
arthurlw 7e5789f
precommit and moved imports to top of files
arthurlw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,14 +7,17 @@ | |
CategoricalDtype, | ||
CategoricalIndex, | ||
DatetimeIndex, | ||
Index, | ||
Interval, | ||
NaT, | ||
Period, | ||
Timestamp, | ||
array, | ||
isna, | ||
to_datetime, | ||
) | ||
import pandas._testing as tm | ||
from pandas.core.arrays.arrow.array import ArrowExtensionArray | ||
|
||
|
||
class TestAstype: | ||
|
@@ -160,3 +163,19 @@ def test_astype_category_readonly_mask_values(self): | |
result = arr.astype("category") | ||
expected = array([0, 1, 2], dtype="Int64").astype("category") | ||
tm.assert_extension_array_equal(result, expected) | ||
|
||
def test_arrow_array_astype_to_categorical_dtype_temporal(self): | ||
|
||
# GH#62051 | ||
arr = array( | ||
["2017-01-01", "2018-01-01", "2019-01-01"], dtype="date32[day][pyarrow]" | ||
) | ||
cats = Index(["2017-01-01", "2018-01-01", "2019-01-01"], dtype="M8[s]") | ||
dtype = CategoricalDtype(categories=cats, ordered=False) | ||
|
||
assert not all(isna(arr.astype(dtype))) | ||
|
||
arr = ArrowExtensionArray._from_sequence(["1h", "2h", "3h"]) | ||
cats = Index(["1h", "2h", "3h"], dtype="m8[ns]") | ||
dtype = CategoricalDtype(cats, ordered=False) | ||
|
||
assert not all(isna(arr.astype(dtype))) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.