Skip to content

BUG: Fix Index.get_level_values() mishandling of boolean, pd.NA, np.nan, and pd.NaT levels #62175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

BUG: Fix Index.get_level_values() mishandling of boolean, pd.NA, np.nan, and pd.NaT levels #62175

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3df788a
BUG: Fix Index.get_level_values() mishandling of boolean, pd.NA, np.n…
whyvineet Aug 23, 2025
fe07d18
CLN: Remove redundant checks for NA, NaT, and NaN in Index class
whyvineet Aug 23, 2025
f57ddc5
CLN: Move import of NA to maintain consistent import order
whyvineet Aug 23, 2025
eca19a2
BUG: Fix Index level validation to handle integer index names correctly
whyvineet Aug 23, 2025
390f3ef
CLN: Remove unnecessary blank line and simplify condition in Index cl…
whyvineet Aug 23, 2025
629bdf9
BUG: Update Index class level validation to use lib.is_integer for ty…
whyvineet Aug 23, 2025
041994c
BUG: Enhance Index level validation to explicitly handle NA values an…
whyvineet Aug 24, 2025
d881247
BUG: Improve Index level validation to reject all NA-like values and …
whyvineet Aug 25, 2025
3e63865
BUG: Update error message for NA-like level validation to include lev…
whyvineet Aug 25, 2025
7f541de
BUG: Enhance index level validation to handle NA-like index names and…
whyvineet Aug 25, 2025
703085e
BUG: Refactor error message formatting in Index class for clarity
whyvineet Aug 25, 2025
3793317
BUG: Refactor index level validation to improve handling of NA-like v…
whyvineet Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pandas/_libs/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
__all__ = [
"NA",
"Interval",
"NaT",
"NaTType",
Expand All @@ -16,6 +17,7 @@
import pandas._libs.pandas_parser # isort: skip # type: ignore[reportUnusedImport]
import pandas._libs.pandas_datetime # noqa: F401 # isort: skip # type: ignore[reportUnusedImport]
from pandas._libs.interval import Interval
from pandas._libs.missing import NA
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems this change is unrelated to the rest of the PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, actually, I was trying something and forgot to undo this change. It's fixed in the latest commit.

from pandas._libs.tslibs import (
NaT,
NaTType,
Expand Down
12 changes: 7 additions & 5 deletions pandas/core/indexes/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2084,7 +2084,7 @@ def _validate_index_level(self, level) -> None:
verification must be done like in MultiIndex.

"""
if isinstance(level, int):
if type(level) is int:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a simple edge case where the Index.name is also an int

Suggested change
if type(level) is int:
if type(level) is int:
if isinstance(self.name, int) and level == self.name:
return

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lib.is_integer

if level < 0 and level != -1:
raise IndexError(
"Too many levels: Index has only 1 level, "
Expand All @@ -2094,10 +2094,12 @@ def _validate_index_level(self, level) -> None:
raise IndexError(
f"Too many levels: Index has only 1 level, not {level + 1}"
)
elif level != self.name:
raise KeyError(
f"Requested level ({level}) does not match index name ({self.name})"
)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this is a better verification that validates what is expected from the documentation.

Suggested change
elif isinstance(level, str) and isinstance(self.name, str) and level != self.name:
raise KeyError(
f"Requested level ({level}) does not match index name ({self.name})"
)

else:
if level != self.name:
raise KeyError(
f"Requested level ({level}) does not match index name ({self.name})"
)

def _get_level_number(self, level) -> int:
self._validate_index_level(level)
Expand Down
Loading