-
-
Notifications
You must be signed in to change notification settings - Fork 19.1k
REF: use _cast_pointwise_result in map #62177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
2fa5d5d
f8f579f
5a60088
494f1b0
645ec56
ca24177
6e1ea1a
ab7da79
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -296,7 +296,7 @@ def __init__(self, groupby_object: groupby.GroupBy) -> None: | |
def __call__( | ||
self, | ||
n: PositionalIndexer | tuple, | ||
dropna: Literal["any", "all", None] = None, | ||
dropna: Literal["any", "all"] | None = None, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pls avoid unrelated changes There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry, but due to a ci check on formatting, I used |
||
) -> DataFrame | Series: | ||
return self.groupby_object._nth(n, dropna) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't want this new keyword.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as the current implementation is not working for all the types, do you have a suggestion on how I should approach this without introducing the new keyword?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as i said here #62177 (comment)