-
-
Notifications
You must be signed in to change notification settings - Fork 19.1k
DOC: definition of a scalar in rich comparison methods #62191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rhshadrach
merged 13 commits into
pandas-dev:main
from
cmp0xff:hotfix/cmp0xff/62063-def-of-scalar
Oct 16, 2025
+79
−8
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f60bf95
doc: definition of a scalar
cmp0xff 288f06e
fix(comment): https://github.com/pandas-dev/pandas/pull/62191#discuss…
cmp0xff 414ffe5
Merge branch 'main' into hotfix/cmp0xff/62063-def-of-scalar
cmp0xff 470d093
fix(comment): https://github.com/pandas-dev/pandas/issues/62063#issue…
cmp0xff 20d5727
Merge branch 'main' into hotfix/cmp0xff/62063-def-of-scalar
cmp0xff 9f26215
fix: ruff
cmp0xff 0ac7c5b
Merge branch 'main' into hotfix/cmp0xff/62063-def-of-scalar
cmp0xff 9edf599
Merge branch 'main' into hotfix/cmp0xff/62063-def-of-scalar
cmp0xff 36bfdef
fix: comments
cmp0xff dc5e9ec
Merge branch 'main' into hotfix/cmp0xff/62063-def-of-scalar
cmp0xff 2175f39
Merge branch 'main' into hotfix/cmp0xff/62063-def-of-scalar
cmp0xff 2b186fd
fix: https://github.com/pandas-dev/pandas/pull/62191#discussion_r2389…
cmp0xff 1c445c3
Merge branch 'main' of github.com:pandas-dev/pandas into hotfix/cmp0x…
cmp0xff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parentheses added here do not help the issue since any Python object can be an element of a Series (even a Series itself can be an element of a Series!). We want to indicate that this method treats lists, tuples, ndarrays, and Series differently from any other Python object. Namely, these types will be evaluated element-by-element whereas every other Python object will be evaluated as a whole against each element of the caller.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
288f06e does it look better?