BUG: rank with object dtype and small values #62036 #62227
Merged
+15
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeeVee99
force-pushed
the
rank-with-object
branch
2 times, most recently
from
ec72ed1 to
2153b5e
Compare
jbrockmendel
reviewed
Sep 1, 2025
jbrockmendel
reviewed
Sep 1, 2025
TeeVee99
force-pushed
the
rank-with-object
branch
from
2153b5e to
0111ea7
Compare
TeeVee99
force-pushed
the
rank-with-object
branch
from
0111ea7 to
0998d24
Compare
Changes : - Cython helper function `are_diff` resulted in a tie for any comparisons where the difference was less than 1e-13, this caused unexpected results. Hence, directly used the comparison operator for all dtypes. - Removed the`are_diff` function since it's no longer required in the code. - Also, added a test case to detect this issue in the future.
TeeVee99
force-pushed
the
rank-with-object
branch
from
0998d24 to
1063ef3
Compare
|
thanks @TeeVee99 |
iabhi4
pushed a commit
to iabhi4/pandas
that referenced
this pull request
Sep 13, 2025
…-dev#62227) Co-authored-by: Tejaswini V <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made -
are_diffresulted in a tie for any comparisons where the difference was less than 1e-13, this caused unexpected results. Hence, directly used the comparison operator for all dtypes.are_difffunction since it's no longer required in the code.<NA>handling unchanged.test_object_dtypefor rank on object-dtype Seriesdoc/source/whatsnew/v3.0.0.rstfile