BUG: DatetimeIndex intersection with non-anchored freq #62341
Conversation
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
@arthurlw are you still working on this? |
|
Hey @jbrockmendel, i've been a bit swamped with classwork lately. I updated the condition in the PR. Lmk if anything needs to be changed! |
| # indexes actually share a common point | ||
| # GH#44025 | ||
| diff = other[0] - self[0] | ||
| if diff != Timedelta(0) and diff.total_seconds() % 86400 != 0: |
There was a problem hiding this comment.
clearer just to write diff != Timedelta(days=1)?
There was a problem hiding this comment.
of never mind, didn't see the %
There was a problem hiding this comment.
i dont think this condition ensures they share a point in common. e.g. what if both freqs are Week and they are offset by one day?
There was a problem hiding this comment.
Assuming the week freqs are created with CDay(7), then self.freq.n is equal to 7 and _can_fast_intersect returns false on the final check:
return self.freq.n == 1If the freqs are "W" then it seems they snap to Sunday regardless of starting offset.
For specific "W" freqs (e.g. "W-MON", "W-TUE") it returns false on this check:
elif other.freq != self.freq:
return FalseThere was a problem hiding this comment.
Assuming the week freqs are created with CDay(7)
Why would you assume that. I was thinking pd.offsets.Week(1)
2 participants
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.