Skip to content

Conversation

mroeschke
Copy link
Member

e.g. https://github.com/pandas-dev/pandas/actions/runs/17741519922/job/50416374964

A way to better type _book can be done in a follow up.

@mroeschke mroeschke added this to the 3.0 milestone Sep 15, 2025
@mroeschke mroeschke added the Typing type annotations, mypy/pyright type checking label Sep 15, 2025
@Alvaro-Kothe
Copy link
Member

Alvaro-Kothe commented Sep 15, 2025

I've raised an issue on xlsxwriter jmcnamara/XlsxWriter#1152 and a patch is available on version 3.2.7 that would fix this issue, which is available on pypi, but not on conda-forge.

@mroeschke
Copy link
Member Author

Going to merge this to get the CI to green, but we can undo this once the new version of xlswriter is on conda forge. Thanks for investigating @Alvaro-Kothe

@mroeschke mroeschke merged commit e503c13 into pandas-dev:main Sep 15, 2025
45 checks passed
@mroeschke mroeschke deleted the fix/typing branch September 15, 2025 20:33
@simonjayhawkins
Copy link
Member

Thanks @mroeschke

@rhshadrach rhshadrach added the IO Excel read_excel, to_excel label Sep 15, 2025
@jorisvandenbossche jorisvandenbossche modified the milestones: 3.0, 2.3.3 Sep 20, 2025
@jorisvandenbossche
Copy link
Member

@meeseeksdev backport to 2.3.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IO Excel read_excel, to_excel Typing type annotations, mypy/pyright type checking

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants