BUG: Fix cast_pointwise_result with all-NA values #62352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Whether to convert datetime, timedelta, period, interval types. | ||
| dtype_if_all_na : np.dtype, ExtensionDtype, or None, default None | ||
| Dtype to cast to if we have all-NA or all-None. | ||
| dtype_if_all_nat : np.dtype, ExtensionDtype, or None, default None |
There was a problem hiding this comment.
can this replace dtype_if_all_nat instead of adding a new arg?
There was a problem hiding this comment.
never mind, i now see that isnt viable.
There was a problem hiding this comment.
Yes, It seems not easy. the details are above. #62352 (comment)
There will be pros and cons, but I think the logic of _cast_pointwise_result is that the current version is clearer. (d5c6cfb)
This reverts commit d5c6cfb.
|
thanks @heoh |
jzwick
pushed a commit
to jzwick/pandas
that referenced
this pull request
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Description
Fix a bug in
BaseMaskedArray._cast_pointwise_resultwith all-NA values results returnedobjectdtype instead of preserving the original dtype.Additional Notes
In the original issue report the behavior was described for
BooleanDtype. While preparing the fix, I added tests not only forBooleanDtypebut also for integer dtype under the same all-NA condition. I thought it would be reasonable to ensure consistency across multiple ExtensionArray types.If this is out of scope or unnecessary for this PR, please let me know and I will modify the test for only the Boolean case, as reported in the issue.