TST: test that re-using a list of groupers will not throw ValueError #62374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Could you run the pre-commit checks? |
mroeschke
added
the
Testing
|
@mroeschke All checks passed. |
mroeschke
approved these changes
Sep 19, 2025
|
Thanks @jarent-nvidia |
jzwick
pushed a commit
to jzwick/pandas
that referenced
this pull request
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pd.groupbyseems to mutate mypd.Grouperin-place #26564Added test to ensure that pd.Grouper is immutable as list item and can be safely reused in different DataFrames. I run the same test on older pandas version (1.3.5) and ensured that the test fails with an error:
ValueError: all keys need to be the same shape