BUG: Fix dt64[non_nano] + some_offsets incorrectly rounding #62383
+40
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
reviewed
Oct 4, 2025
pandas/core/arrays/datetimes.py
Outdated
|
|
||
| else: | ||
| result = type(self)._simple_new(res_values, dtype=res_values.dtype) | ||
| units = ["ns", "us", "ms", "s", "m", "h", "D"] |
There was a problem hiding this comment.
No, I'm wrong I will update this .
jbrockmendel
reviewed
Oct 4, 2025
| idx_self = units.index(self.unit) | ||
| idx_offset = units.index(offset_unit) | ||
| res_unit = units[min(idx_self, idx_offset)] | ||
| dtype = tz_to_dtype(self.tz, unit=res_unit) |
There was a problem hiding this comment.
wont you need to cast res_values before calling simple_new?
There was a problem hiding this comment.
yes, thanks! . Should we wrap this in try/except block?
There was a problem hiding this comment.
i suspect that The Right Way to do this would be to find the correct dtype before calling _from_sequence on L817 and pass it there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates logic selects the finest unit between the array and the offset, preventing rounding errors. A regression test is included to confirm correct behavior for affected offsets and units.
Please let me know if my approach or fix needs any improvements . I’m open to feedback and happy to make changes based on suggestions.
Thankyou !