Skip to content

BUG: drop pyqt5 dependency in docker for linux/arm #62422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 23, 2025
Merged

BUG: drop pyqt5 dependency in docker for linux/arm #62422

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6cdb284
fix(Dockerfile): don't install PyQt5 on linux/arm
Alvaro-Kothe Sep 23, 2025
ad48788
ci(docker): build on arm64
Alvaro-Kothe Sep 23, 2025
d0c81d6
Revert "ci(docker): build on arm64"
Alvaro-Kothe Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions .github/workflows/code-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,15 +132,22 @@ jobs:
asv run --quick --dry-run --durations=30 --python=same --show-stderr

build_docker_dev_environment:
name: Build Docker Dev Environment
runs-on: ubuntu-24.04
name: Build Docker Dev Environment (${{ matrix.arch }})
runs-on: ${{ matrix.platform }}
strategy:
matrix:
include:
- arch: amd64
platform: ubuntu-24.04
- arch: arm64
platform: ubuntu-24.04-arm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should add arm as a platform in CI, not at least without a better use case for it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was just to check if the changes were successful. I will revert these changes now.

defaults:
run:
shell: bash -el {0}

concurrency:
# https://github.community/t/concurrecy-not-work-for-push/183068/7
group: ${{ github.event_name == 'push' && github.run_number || github.ref }}-build_docker_dev_environment
group: ${{ github.event_name == 'push' && github.run_number || github.ref }}-build_docker_dev_environment-${{ matrix.arch }}
cancel-in-progress: true

steps:
Expand All @@ -153,10 +160,10 @@ jobs:
fetch-depth: 0

- name: Build image
run: docker build --pull --no-cache --tag pandas-dev-env .
run: docker build --pull --no-cache --tag pandas-dev-env-${{ matrix.arch }} .

- name: Show environment
run: docker run --rm pandas-dev-env python -c "import pandas as pd; print(pd.show_versions())"
run: docker run --rm pandas-dev-env-${{ matrix.arch }} python -c "import pandas as pd; print(pd.show_versions())"

requirements-dev-text-installable:
name: Test install requirements-dev.txt
Expand Down
12 changes: 11 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
FROM python:3.11.13
WORKDIR /home/pandas

# https://docs.docker.com/reference/dockerfile/#automatic-platform-args-in-the-global-scope
ARG TARGETPLATFORM

RUN apt-get update && \
apt-get --no-install-recommends -y upgrade && \
apt-get --no-install-recommends -y install \
Expand All @@ -13,7 +16,14 @@ RUN apt-get update && \
rm -rf /var/lib/apt/lists/*

COPY requirements-dev.txt /tmp
RUN python -m pip install --no-cache-dir --upgrade pip && \

RUN case "$TARGETPLATFORM" in \
linux/arm*) \
# Drop PyQt5 for ARM GH#61037
sed -i "/^pyqt5/Id" /tmp/requirements-dev.txt \
;; \
esac && \
python -m pip install --no-cache-dir --upgrade pip && \
python -m pip install --no-cache-dir -r /tmp/requirements-dev.txt
RUN git config --global --add safe.directory /home/pandas

Expand Down
Loading