STY: ZIP strict for pandas/io #62469

LirongMa · 2025-09-26T20:46:53Z

Add strict to zip() call for #62434

[] closes #xxxx (Replace xxxx with the GitHub issue number)
STY: Enforce Ruff rule B905, zip-without-explicit-strict #62434
Tests added and passed if fixing a bug or adding a new feature
All code checks passed.
Added type annotations to new arguments/methods/functions.
Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Alvaro-Kothe

This should fix the problem.

Also, remove the files you modified from pyproject.toml.

Lines 435 to 438 in 179258f

    
           # TODO: Fix B905 (zip-without-explicit-strict) - Remove files below as they're fixed 
        
           # For contributors working on this issue: 
        
           # After adding strict={True,False} to zip() calls in a file, 
        
           # remove its line from this section

Alvaro-Kothe · 2025-09-26T21:47:19Z

pandas/io/parsers/base_parser.py

        clean_dtypes = self._clean_mapping(self.dtype)

        if self.index_names is not None:
            names: Iterable = self.index_names


Suggested change

names: Iterable = self.index_names

names: Iterable = self.index_names

strict = True

Alvaro-Kothe · 2025-09-26T21:47:42Z

pandas/io/parsers/base_parser.py

        if self.index_names is not None:
            names: Iterable = self.index_names
        else:
            names = itertools.cycle([None])


Suggested change

names = itertools.cycle([None])

names = itertools.cycle([None])

strict = False

Alvaro-Kothe · 2025-09-26T21:47:58Z

pandas/io/parsers/base_parser.py

        else:
            names = itertools.cycle([None])
-        for i, (arr, name) in enumerate(zip(index, names)):
+        for i, (arr, name) in enumerate(zip(index, names, strict=True)):


Suggested change

for i, (arr, name) in enumerate(zip(index, names, strict=True)):

for i, (arr, name) in enumerate(zip(index, names, strict=strict)):

@Alvaro-Kothe I made the changes per your request.

…#62510)

…-dev#62469 (pandas-dev#62510)

Alvaro-Kothe

Looking good overall. Just need to know why you had to use strict=False in some places.

Alvaro-Kothe · 2025-10-04T12:43:20Z

pandas/io/formats/format.py

                ]
-                for i, (x, dtype) in enumerate(zip(fmt_columns, self.frame.dtypes))
+                for i, (x, dtype) in enumerate(
+                    zip(fmt_columns, self.frame.dtypes, strict=False)


Why is this False?

Alvaro-Kothe · 2025-10-04T12:43:33Z

pandas/io/formats/html.py

                idx_values = list(
-                    zip(*frame.index._format_multi(sparsify=False, include_names=False))
+                    zip(
+                        *frame.index._format_multi(sparsify=False, include_names=False),


Why is this False?

Alvaro-Kothe · 2025-10-04T12:43:38Z

pandas/io/formats/info.py

            max(*widths)
-            for widths in zip(self.header_column_widths, body_column_widths)
+            for widths in zip(
+                self.header_column_widths, body_column_widths, strict=False


Why is this False?

Alvaro-Kothe · 2025-10-04T12:44:33Z

pandas/io/parsers/c_parser_wrapper.py

                self._check_data_length(names, alldata)

-            data = {k: v for k, (i, v) in zip(names, data_tups)}
+            data = {k: v for k, (i, v) in zip(names, data_tups, strict=False)}


Why this one needs to be False, and the one above doesn't?

Alvaro-Kothe · 2025-10-04T12:45:03Z

pandas/io/xml.py

                    **{
                        nm: ch.text if ch.text else None
-                        for nm, ch in zip(self.names, el.findall("*"))
+                        for nm, ch in zip(self.names, el.findall("*"), strict=False)


Why is this False?

Alvaro-Kothe · 2025-10-04T12:45:26Z

pandas/io/formats/excel.py

+                    level_lengths,
+                    self.df.index.levels,
+                    self.df.index.codes,
+                    strict=False,


Why is this False?

@Alvaro-Kothe the tests failed on these calls. Once I changed to False, all tests passed.

Alvaro-Kothe

LGTM

mroeschke · 2025-10-04T16:18:48Z

Thanks @LirongMa

LirongMa added 3 commits September 25, 2025 01:06

strict to true for info

9a1c452

Merge branch 'pandas-dev:main' into main

ee2bf48

add strict to true for zip

ccdc4f5

LirongMa requested review from attack68 and rhshadrach as code owners September 26, 2025 20:46

LirongMa mentioned this pull request Sep 26, 2025

STY: Enforce Ruff rule B905, zip-without-explicit-strict #62434

Closed

Alvaro-Kothe suggested changes Sep 26, 2025

View reviewed changes

shivamvishal added a commit to shivamvishal/pandas that referenced this pull request Sep 27, 2025

Zip Strict for pandas/plotting pandas-dev#62469

d62f24f

LirongMa added 3 commits September 28, 2025 15:04

Merge branch 'pandas-dev:main' into main

70a8357

merege

e431a8b

remove io files from pyproject

8065ce1

LirongMa changed the title ~~Zip Strict for pandas/io~~ [Issue #62434] - Enforce Ruff rule B905, zip-without-explicit-strict for pandas/io Sep 28, 2025

LirongMa added 5 commits September 28, 2025 19:29

set strict to false in format.py

e5a9750

strict to be false for some

ce141ba

strict to false

b70e14e

more more false

3591b11

false

3c2d0c0

mroeschke pushed a commit that referenced this pull request Sep 29, 2025

Zip Strict for pandas/plotting #62469 (#62478)

d18f9a2

mroeschke pushed a commit that referenced this pull request Sep 30, 2025

Zip Strict for pandas/core/computation and pandas/core/groupby #62469 (…

bcb99d5

…#62510)

jzwick pushed a commit to jzwick/pandas that referenced this pull request Oct 1, 2025

Zip Strict for pandas/plotting pandas-dev#62469 (pandas-dev#62478)

23f35b3

jzwick pushed a commit to jzwick/pandas that referenced this pull request Oct 1, 2025

Zip Strict for pandas/core/computation and pandas/core/groupby pandas…

29f79f4

…-dev#62469 (pandas-dev#62510)

LirongMa added 3 commits October 1, 2025 19:49

Merge branch 'pandas-dev:main' into main

bae4e48

pull main

2f79a25

update pyproject.toml

3da45c3

LirongMa changed the title ~~[Issue #62434] - Enforce Ruff rule B905, zip-without-explicit-strict for pandas/io~~ [Issue #62434] - ZIP strict for pandas/io Oct 2, 2025

mroeschke pushed a commit that referenced this pull request Oct 2, 2025

Zip Strict for pandas/util and pandas/_libs #62469 (#62540)

8acec7a

LirongMa added 2 commits October 3, 2025 16:04

Merge branch 'pandas-dev:main' into main

c324360

merge

85b57de

LirongMa changed the title ~~[Issue #62434] - ZIP strict for pandas/io~~ STY: ZIP strict for pandas/io Oct 3, 2025

LirongMa requested a review from Alvaro-Kothe October 4, 2025 09:13

shivamvishal added a commit to shivamvishal/pandas that referenced this pull request Oct 4, 2025

Zip Strict for pandas/core level files pandas-dev#62469

d52e4aa

Alvaro-Kothe reviewed Oct 4, 2025

View reviewed changes

Alvaro-Kothe approved these changes Oct 4, 2025

View reviewed changes

mroeschke added the Code Style Code style, linting, code_checks label Oct 4, 2025

mroeschke added this to the 3.0 milestone Oct 4, 2025

mroeschke approved these changes Oct 4, 2025

View reviewed changes

mroeschke merged commit f570026 into pandas-dev:main Oct 4, 2025
89 checks passed

mroeschke pushed a commit that referenced this pull request Oct 4, 2025

Zip Strict for pandas/core level files #62469 (#62577)

54b8f29

	# TODO: Fix B905 (zip-without-explicit-strict) - Remove files below as they're fixed
	# For contributors working on this issue:
	# After adding strict={True,False} to zip() calls in a file,
	# remove its line from this section

	names: Iterable = self.index_names
	names: Iterable = self.index_names
	strict = True

	names = itertools.cycle([None])
	names = itertools.cycle([None])
	strict = False

	for i, (arr, name) in enumerate(zip(index, names, strict=True)):
	for i, (arr, name) in enumerate(zip(index, names, strict=strict)):

Uh oh!

STY: ZIP strict for pandas/io #62469

STY: ZIP strict for pandas/io #62469

Uh oh!

Conversation

LirongMa commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Alvaro-Kothe left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Alvaro-Kothe left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Alvaro-Kothe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mroeschke commented Oct 4, 2025

Uh oh!

Uh oh!

LirongMa commented Sep 26, 2025 •

edited

Loading