BUG: honor ambiguous/nonexistent for tz-aware endpoints in date_range #62493
+34
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Sep 29, 2025
| end = Timestamp("1916-12-01", tz="Europe/Oslo") | ||
| res = date_range(start, end, freq="MS", ambiguous=True) | ||
| exp = date_range( | ||
| "1916-08-01", "1916-12-01", freq="MS", tz="Europe/Oslo", ambiguous=True |
There was a problem hiding this comment.
Could you add another test that uses nonexistent?
mroeschke
reviewed
Sep 29, 2025
Co-authored-by: Matthew Roeschke <[email protected]>
…angel/pandas into fix-date_range-ambiguous
mroeschke
reviewed
Sep 29, 2025
Comment on lines
1760
to
1768
| expected = [ | ||
| Timestamp("2015-03-28 01:30:00+00:00"), | ||
| Timestamp( | ||
| "2015-03-29 02:00:00+01:00" | ||
| ), # shifted forward over next valid wall time | ||
| Timestamp("2015-03-30 01:30:00+01:00"), | ||
| ] | ||
|
|
||
| assert list(result) == expected |
There was a problem hiding this comment.
Can you use tm.assert_index.equal to compare here?
There was a problem hiding this comment.
Updated the expected block to ensure dtype and freq match the date_range result.
mroeschke
approved these changes
Oct 1, 2025
|
Thanks @floura-angel |
jzwick
pushed a commit
to jzwick/pandas
that referenced
this pull request
Oct 1, 2025
…pandas-dev#62493) Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests in
pandas/tests/indexes/datetimes/test_date_range.py.(Not applicable — no new public API.)
doc/source/whatsnew/vX.X.X.rstfile under Bug fixes → Timezones.