BUG: Take method of NumpyExtensionArray now returns another extension array with the correct dtype. #62502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…take method to return correct dtype.
rhshadrach
added
Bug
ExtensionArray
|
Several tests are currently failing due to a new version of |
jbrockmendel
reviewed
Oct 9, 2025
| fill_value=fill_value, | ||
| axis=axis, | ||
| ) | ||
| if self.dtype in [ |
There was a problem hiding this comment.
Do this on the NumpySemantics instead of this mixin
jbrockmendel
reviewed
Oct 9, 2025
|
|
||
|
|
||
| @pytest.mark.parametrize("dtype", [np.uint32, np.uint64, np.int32, np.int64]) | ||
| def test_take_assigns_correct_dtype(dtype): |
There was a problem hiding this comment.
Comment pointing back to the motivating GH issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the edge case when called with integer arrays and asked to access non-existent entries (to be replaced with NaN), the
takemethod ofNumpyExtensionArrayproduces arrays whose dtypes don't match their underlying data.Specifically,
takepromotes the underlying data to a floating-point type, but doesn't promote the dtype of the extension array to match.These changes ensure that the result of this method has the correct dtype for its data.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.