Add tests for date parsing when display.date_dayfirst and display.date_yearfirst are set #62511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_yearfirst are set
mroeschke
requested changes
Sep 30, 2025
pandas/tests/tslibs/test_parsing.py
Outdated
| @pytest.mark.parametrize("input", ["21-01-01", "01-01-21"]) | ||
| @pytest.mark.parametrize("dayfirst", [True, False]) | ||
| def test_parse_datetime_string_with_reso_dayfirst(dayfirst, input): | ||
| set_option("display.date_dayfirst", dayfirst) |
There was a problem hiding this comment.
Can you use the option_context context manager instead (and below)?
mroeschke
added
the
Testing
mroeschke
approved these changes
Oct 5, 2025
|
Thanks @harinik |
jzwick
pushed a commit
to jzwick/pandas
that referenced
this pull request
Oct 8, 2025
…e_yearfirst are set (pandas-dev#62511) Co-authored-by: Harini Krishnamurthy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for #43164
date_dayfirstanddate_yearfirstconflict #43164 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.