Skip to content

Conversation

Alvaro-Kothe
Copy link
Member

@Alvaro-Kothe Alvaro-Kothe commented Oct 2, 2025

Remove expected warning from NumExpr for + and * operators in boolean arrays for numexpr>=2.13.1.

It seems it was implemented on pydata/numexpr#536.

I think this will make the CI green again.

closes #62545

Remove expected warning for numexpr >=2.13.1.
@mroeschke mroeschke added this to the 2.3.4 milestone Oct 3, 2025
@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Oct 3, 2025
@mroeschke mroeschke merged commit c8213d1 into pandas-dev:main Oct 3, 2025
47 checks passed
@mroeschke
Copy link
Member

Great! Thanks so much @Alvaro-Kothe

Copy link

lumberbot-app bot commented Oct 3, 2025

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.3.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 c8213d16d98079da2a7b7464b95fe22f7d72d427
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #62553: TST: remove expected warnings for new `numexpr` version'
  1. Push to a named branch:
git push YOURFORK 2.3.x:auto-backport-of-pr-62553-on-2.3.x
  1. Create a PR against branch 2.3.x, I would have named this PR:

"Backport PR #62553 on branch 2.3.x (TST: remove expected warnings for new numexpr version)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@Alvaro-Kothe Alvaro-Kothe deleted the test/new-numexpr branch October 3, 2025 13:19
Alvaro-Kothe added a commit to Alvaro-Kothe/pandas that referenced this pull request Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Still Needs Manual Backport Testing pandas testing functions or related to the test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Some existing tests are now failing for latest numexpr version 2.13.. Addition and Multiplication of Booleans no longer issues the expected warning

2 participants