BUG : Fix Excel header NaN duplication with merged MultiIndex columns in to_excel #62576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justine202429
force-pushed
the
bugfix-Issue62340
branch
from
6703b44 to
a5784f5
Compare
mathbruu
force-pushed
the
bugfix-Issue62340
branch
from
a5784f5 to
b34c5d6
Compare
justine202429
force-pushed
the
bugfix-Issue62340
branch
from
af60451 to
a85715d
Compare
justine202429
force-pushed
the
bugfix-Issue62340
branch
from
a85715d to
5f70c16
Compare
Member
Alvaro-Kothe
left a comment
Alvaro-Kothe
left a comment
There was a problem hiding this comment.
It needs tests and an entry in whatsnew.
mathbruu
force-pushed
the
bugfix-Issue62340
branch
from
fbdd7dc to
1eaf805
Compare
mathbruu
force-pushed
the
bugfix-Issue62340
branch
from
1eaf805 to
1b5fe97
Compare
Alvaro-Kothe
suggested changes
Oct 19, 2025
Comment on lines
1597
to
1600
| with ExcelWriter("test.xlsx", engine="openpyxl") as writer: | ||
| df.to_excel(writer, sheet_name="Sheet1", merge_cells=merge_cells) | ||
|
|
||
| reader = ExcelFile("test.xlsx") |
Member
There was a problem hiding this comment.
Don't read and write to CWD, either use a temporary file, or use an in-memory buffer.
| DummyClass.assert_called_and_reset() | ||
|
|
||
| @td.skip_if_no("openpyxl") | ||
| def test_to_excel_multiindex_nan_in_columns(self, merge_cells): |
Comment on lines
1601
to
1605
| result = pd.read_excel(reader, index_col=0, header=[0, 1]) | ||
|
|
||
| original_values = df.to_numpy() | ||
| result_values = result.to_numpy() | ||
| tm.assert_numpy_array_equal(original_values, result_values) |
Member
There was a problem hiding this comment.
Create an expected DataFrame and use tm.assert_frame_equal
|
pre-commit.ci autofix |
mathbruu
force-pushed
the
bugfix-Issue62340
branch
from
2dad8cc to
77422bf
Compare
|
done |
| with ExcelFile(tmp_excel) as reader: | ||
| result = pd.read_excel(reader, index_col=0, header=[0, 1]) | ||
|
|
||
| tm.assert_numpy_array_equal(result.to_numpy(), df.to_numpy()) |
Member
There was a problem hiding this comment.
This doesn't test the header.
| buf = BytesIO() | ||
| df.to_excel(buf) | ||
|
|
||
| def test_to_excel_multiindex_nan_in_columns(self, merge_cells, tmp_excel): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.