Skip to content

Zip strict strings #62605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2025
+3 −3
Merged

Zip strict strings #62605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
036b2a5
Add explict strict=True to zip() calls
asoledad33 Oct 6, 2025
157a6a0
Remove Ruff check for pandas/core/strings
asoledad33 Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pandas/core/strings/accessor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ def _wrap_result(
)
result = {
label: ArrowExtensionArray(pa.array(res))
for label, res in zip(name, result.T)
for label, res in zip(name, result.T, strict=True)
}
elif is_object_dtype(result):

Expand Down Expand Up @@ -684,7 +684,8 @@ def cat(
elif na_rep is not None and union_mask.any():
# fill NaNs with na_rep in case there are actually any NaNs
all_cols = [
np.where(nm, na_rep, col) for nm, col in zip(na_masks, all_cols)
np.where(nm, na_rep, col)
for nm, col in zip(na_masks, all_cols, strict=True)
]
result = cat_safe(all_cols, sep)
else:
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,6 @@ exclude = [
"pandas/core/reshape/merge.py" = ["B905"]
"pandas/core/reshape/pivot.py" = ["B905"]
"pandas/core/reshape/reshape.py" = ["B905"]
"pandas/core/strings/accessor.py" = ["B905"]
"pandas/core/window/rolling.py" = ["B905"]
"pandas/_testing/asserters.py" = ["B905"]
"pandas/_testing/_warnings.py" = ["B905"]
Expand Down
Loading