Fix/53098 numeric only disallow non bools #62632
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ecf23e1.
…ne during 2.x)\n\nAdds a centralized helper that emits a PandasFutureWarning for numeric_only=None to support a warn-first migration (GH#53098).
…recate_numeric_only_none and validate_bool_kwarg at central reduction entry points (DataFrame._reduce, Series._reduce, GroupBy._cython_agg_general, Rolling._validate_numeric_only). Emit PandasFutureWarning for numeric_only=None (GH#53098).
…numeric_only=None using tm.assert_produces_warning
Contributor
Author
|
I see some tests failing, which I couldn't catch locally. Any suggestion on what I am missing will be helpful. |
Member
|
Some of them can be fixed if you merge from main. |
jbrockmendel
reviewed
Nov 3, 2025
| # validate numeric_only is strictly a bool (disallow None, ints, etc.) | ||
| # Deprecate passing None to numeric_only: warn now, error in a future | ||
| # release. See GH#53098. | ||
| from pandas.util._validators import deprecate_numeric_only_none |
Member
There was a problem hiding this comment.
do this import at the top of the file
jbrockmendel
reviewed
Nov 3, 2025
| # Note: we never get here with how="ohlc" for DataFrameGroupBy; | ||
| # that goes through SeriesGroupBy | ||
|
|
||
| # validate numeric_only is strictly a bool (disallow None, ints, etc.) |
Member
There was a problem hiding this comment.
this comment can go in the implementation of deprecate_numeric_only_none, is not needed at every place where it is called
jbrockmendel
reviewed
Nov 3, 2025
| # New behavior: numeric_only=None is deprecated; emit a warning but | ||
| # continue to accept it during the deprecation period. | ||
| if numeric_only is None: | ||
| from pandas import errors |
Member
There was a problem hiding this comment.
top of the file, should probably be Pandas4Warning?
jbrockmendel
reviewed
Nov 3, 2025
| return value | ||
|
|
||
|
|
||
| # deprecate_numeric_only_none defined later in file |
jbrockmendel
reviewed
Nov 3, 2025
| """ | ||
| import warnings | ||
|
|
||
| from pandas import errors |
jbrockmendel
reviewed
Nov 3, 2025
| f'Passing None for "{arg_name}" is deprecated and will raise a ' | ||
| "ValueError in a future version; please pass True or False." | ||
| ) | ||
| warnings.warn(msg, errors.PandasFutureWarning, stacklevel=2) |
Member
There was a problem hiding this comment.
use stacklevel=find_stack_level()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numeric_onlyin reduction operations should disallow passing non-bools #53098 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Ran tests:
Groupby tests: 29766 passed, 440 skipped, 45 xfailed, 39 xpassed, 1 warning.
Window tests (with Numba disabled to avoid an env crash): 9869 passed, 28 skipped, 91 xfailed.
Frame reductions tests: 2338 passed, 2 xfailed.
No real test failures (only xfails/skips) after applying the deprecation behavior.
Changes
Implemented the deprecation approach for numeric_only=None during the 2.x cycle:
frame.py : (DataFrame._reduce)
series.py : (Series._reduce)
groupby.py :(GroupBy._cython_agg_general)
rolling.py : (Rolling._validate_numeric_only)