BUG: handle overflow during exponent parsing in read_csv
#62741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alvaro-Kothe
force-pushed
the
fix/double-segfault
branch
from
b364bdf to
5912e82
Compare
WillAyd
requested changes
Oct 21, 2025
WillAyd
approved these changes
Oct 21, 2025
Member
|
Great thanks @Alvaro-Kothe |
3 tasks
mittal-aakriti
pushed a commit
to mittal-aakriti/pandas
that referenced
this pull request
Nov 19, 2025
mittal-aakriti
pushed a commit
to mittal-aakriti/pandas
that referenced
this pull request
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read_csvis inconsistent with large exponent #62740doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.This patch uses
strtolto compute the exponent and checks overflow by theerrnoassigned onstrtoland withchecked_add.I deleted the previous tests regarding large exponents because they were validating the undefined behavior caused by the overflow, where in one test asserts that
10E-99999999999999999is parsed as0.0, while on the other10E-999999999999999999(contains 1 digit more) is parsed as a string.Now, the float parsing on overflow follows the results from
pyarrow.