Skip to content

GH 25298: Add test for interval index in multiindex #62794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

GH 25298: Add test for interval index in multiindex #62794

Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
276211a
GH 25298: Add test for interval index in multiindex
harinik Oct 22, 2025
2f5fa2a
whitespace
harinik Oct 22, 2025
6f6e0f6
lint
harinik Oct 22, 2025
0325998
lint once more
harinik Oct 22, 2025
456ae7c
move test
harinik Oct 24, 2025
a7e9a4e
fix test
harinik Oct 30, 2025
73cea1f
fix test
harinik Nov 4, 2025
cf10cf7
fix series name
harinik Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pandas/tests/indexing/interval/test_interval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,3 +222,13 @@ def test_reindex_behavior_with_interval_index(self, base):
expected_result = Series([np.nan, 0], index=[np.nan, 1.0], dtype=float)
result = ser.reindex(index=[np.nan, 1.0])
tm.assert_series_equal(result, expected_result)

def test_multiindex_with_interval_index(self):
# for GH#25298
intIndex = IntervalIndex.from_arrays([1, 5, 8, 13, 16], [4, 9, 12, 17, 20])
multiIndex = pd.MultiIndex.from_arrays([["a", "a", "b", "b", "c"], intIndex])
data = [(1, 2), (3, 4), (5, 6), (7, 8), (9, 10)]
df = DataFrame(data, index=multiIndex)
result1 = df.loc[("b", 16)]
Copy link
Contributor

@natmokval natmokval Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harinik, one small comment: could you please rename result1 to result?

Copy link
Contributor Author

@harinik harinik Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

expected = Series([7, 8])
tm.assert_series_equal(result1, expected, check_names=False)
Copy link
Member

@mroeschke mroeschke Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a name= to the Series so we do not need to call check_names=False?

Copy link
Contributor

@natmokval natmokval Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harinik, in case you need help with this comment:
When you define

expected = Series([7, 8], name=('b', Interval(13, 17, closed='right')))

your test should work without passing check_names=False.
(import Interval as well)

Copy link
Contributor Author

@harinik harinik Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did that but it did not work for some reason. When I tried changing it to:

expected = Series([7, 8], name="('b', Interval(13, 17, closed='right'))")

and removed check_names=False it fails with:

E       Attribute "name" are different
E       [left]:  ('b', Interval(13, 17, closed='right'))
E       [right]: ('b', Interval(13, 17, closed='right'))

I am not quite sure what I am doing wrong.

Copy link
Contributor

@natmokval natmokval Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the name has type tuple, not a string (just remove the quotes)

Copy link
Contributor Author

@harinik harinik Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I hadn't realized that, thank you for catching. Fixed now.

Loading