Skip to content

BUG: define __Pyx_PyUnstable_Object_IsUniqueReferencedTemporary for python<3.14 #63129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −1
Open

BUG: define __Pyx_PyUnstable_Object_IsUniqueReferencedTemporary for python<3.14 #63129

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16b302c
fix: implement IsUniqueRefTemp for python<3.14
Alvaro-Kothe Nov 16, 2025
6b4564c
chore: comment why function is declared
Alvaro-Kothe Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pandas/_libs/internals.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1006,8 +1006,11 @@ cdef class BlockValuesRefs:

cdef extern from "Python.h":
"""
// python version < 3.14
#if PY_VERSION_HEX < 0x030E0000
int __Pyx_PyUnstable_Object_IsUniqueReferencedTemporary(PyObject *ref);
int __Pyx_PyUnstable_Object_IsUniqueReferencedTemporary(PyObject *ref) {
return Py_REFCNT(ref) == 1;
Copy link
Member

@jorisvandenbossche jorisvandenbossche Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment here that this is unused and just added to avoid a build warning?

Copy link
Member Author

@Alvaro-Kothe Alvaro-Kothe Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

I actually had to define it to prevent import errors in debug builds. When you build with optimizations, the compiler removes the declaration, but debug builds has this symbol undefined, which causes import errors.

}
#else
#define __Pyx_PyUnstable_Object_IsUniqueReferencedTemporary \
PyUnstable_Object_IsUniqueReferencedTemporary
Expand Down
Loading