ENH: Cast ndarray-like datetime64 arrays to Index properly #7468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that the ndarray-like arrays of dtype datetime64 were not being properly cast to an Index, because -- due to a bug with np.datetime64 -- calling np.asarray(x, dtype=object) if x is an ndarray of type datetime64 results in an *integer* array. This PR adds tests and a work around to pd.Index.__new__. Related pandas-dev#5460
jreback
added a commit
that referenced
this pull request
Jun 16, 2014
ENH: Cast ndarray-like datetime64 arrays to Index properly
|
thanks seem inocuous enough....famous last words though :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the ndarray-like arrays of dtype
datetime64werenot being properly cast to an
Index, because -- due to a bug withnp.datetime64-- callingnp.asarray(x, dtype=object)if x is anndarray of type
datetime64results in an integer array.This PR adds tests and a work around to
pd.Index.__new__.Related #5460