Skip to content

Conversation

toddrjen
Copy link
Contributor

This includes the requested fix for nanops, using common.is_*_dtype functions whenever possible.

@toddrjen
Copy link
Contributor Author

This can be easily split into two pull requests if you want. This seems like a very small change so I wasn't sure.

I can also squash the first two commits. I felt it was better at least for the review to have them separate for clarity, but before the actual merge I would guess you would probably want them squashed.

@jreback
Copy link
Contributor

jreback commented Jun 22, 2014

this is ok
just squash and ping me on green

if u r interested ther are lots of dtype comparisons which need fixing to use these functions all over the library (eg dtype == object) is pretty prevalent

also u can directly import these (instead of using com.is_...)

@jreback jreback added this to the 0.14.1 milestone Jun 23, 2014
@toddrjen
Copy link
Contributor Author

This seems to be ready now. travis is green and the first patch has been squashed.

@jreback
Copy link
Contributor

jreback commented Jun 24, 2014

can run a perf check and post anything big
(should be ok but just checking)

@toddrjen
Copy link
Contributor Author

There are no major performance regressions.

jreback added a commit that referenced this pull request Jun 26, 2014
@jreback jreback merged commit f8b101c into pandas-dev:master Jun 26, 2014
@jreback
Copy link
Contributor

jreback commented Jun 26, 2014

thanks!

@toddrjen toddrjen deleted the nanopsclean branch June 26, 2014 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Internals Related to non-user accessible pandas implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants