-
-
Notifications
You must be signed in to change notification settings - Fork 19.1k
CI: Drop numpy 1.6 support #7954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
well that was cathartic |
fyi, your 2.6/2.7_locale build are prob taking forever as they have to compie numpy (until the wheel is there) |
yeah i know .. there's some fails too |
i think we might need to require 1.7.1, there's an issue with type coercion in ufuncs in 1.7.0 not totally sure what the issue is taking a look now |
arg nope 1.7.1 still fails |
pandas/tests/test_series.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line too
ok wheels are up for 1.7.0/1.7.1 on both 2.6 and 2.7_LOCALE enjoy! |
I'm going to close this until i make some more progress |
whoops wrong pr |
This will pass but there's a weird bug where with tm.assertRaises(ValueError):
o.item() will fail but self.assertRaises(ValueError, o.item) will pass there might be a weird py26 bug in this decorator ... let me see if i can't dig around and fix it |
@jreback @jorisvandenbossche Any comments? The assert raises issue only shows up on Travis, even when I use the exact same deps. |
yeh I think their might be something in the decorator I always use:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not tested anywhere I assume (as we are not running builds like this), but give a test manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested this
not totally sure how you'd even get past the setup.py
but this will raise if somehow you do
need to update |
Cool. Will do. You actually don't need a lambda in those cases because the function is already a no argument callable. A bit easier to read IMO |
@jreback good to go? |
i'll squash if you watn |
doc/source/v0.15.0.txt
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add this to highlites too (I know its sort of duplicated but that's ok)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i just moved it up to right above the "Highlights include"
version is also mentioned in the readme |
minor comments (I would squash). ok otherwise |
alright if this next build passes going to merge @jorisvandenbossche thanks for the heads up about the readme |
ok sure |
this is passing on my fork, travis is going to take forever to get to this i guess can merge tomorrow |
if passing then ok to merge |
closes #7711