Skip to content

BUG: LooseVersion was used incorrectly #8587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

BUG: LooseVersion was used incorrectly #8587

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
903c580
Bugfix -- LooseVersion was used incorrectly
pallav-fdsi Oct 20, 2014
8a09ee6
BUG: LooseFix did not treat 2.0 >= 2.00
pallav-fdsi Oct 20, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pandas/io/gbq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
_GOOGLE_API_CLIENT_INSTALLED=True
_GOOGLE_API_CLIENT_VERSION = pkg_resources.get_distribution('google-api-python-client').version

if LooseVersion(_GOOGLE_API_CLIENT_VERSION >= '1.2.0'):
if LooseVersion(_GOOGLE_API_CLIENT_VERSION) >= '1.2.0':
_GOOGLE_API_CLIENT_VALID_VERSION = True

except ImportError:
Expand All @@ -56,7 +56,7 @@

_GOOGLE_FLAGS_VERSION = pkg_resources.get_distribution('python-gflags').version

if LooseVersion(_GOOGLE_FLAGS_VERSION >= '2.0.0'):
if LooseVersion(_GOOGLE_FLAGS_VERSION) >= '2.0':
_GOOGLE_FLAGS_VALID_VERSION = True

except ImportError:
Expand Down