BUG: fix writing of Categorical with to_sql (GH8624) #8682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needs big doc note that these are converted to object on serialization (to reading back does NOT generate a categorical) |
|
yes, OK, in the io.rst docs for sql? |
|
needs big doc note that these are converted to object on serialization (to reading back does NOT generate a categorical) |
jorisvandenbossche
force-pushed
the
sql-8624-categorical
branch
from
024446b to
94935c1
Compare
Use .get_values() instead of .values on the block, this ensures that NonConsolidatable blocks (non-dense blocks like categorical or sparse) are densified instead of just returning the raw .values
jorisvandenbossche
force-pushed
the
sql-8624-categorical
branch
from
94935c1 to
2d711e0
Compare
|
@jreback added a doc note. |
jorisvandenbossche
added a commit
that referenced
this pull request
Oct 31, 2014
BUG: fix writing of Categorical with to_sql (GH8624)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8624
Use .get_values() instead of .values on the block,
this ensures that NonConsolidatable blocks (non-dense
blocks like categorical or sparse) are densified
instead of just returning the raw .values.