Skip to content

docfix: add boolean array as option for indexing with .iloc #8970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

docfix: add boolean array as option for indexing with .iloc #8970

wants to merge 3 commits into from

Conversation

cswarth
Copy link
Contributor

@cswarth cswarth commented Dec 2, 2014

resolves #8956 Trivial documentation addition of boolean array as option for .iloc

@jreback jreback added Docs Indexing Related to indexing on series/frames, not to indexes themselves labels Dec 3, 2014
jreback
jreback reviewed Dec 3, 2014
View reviewed changes
doc/source/indexing.rst
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

their is another section at the very top of indexing.rst where .iloc/.loc are described similarly. pls add there as necessary as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it the Different Choices and the Selection By Position sections

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I hope this is what you were referring to. Tried to make minimal changes as necessary.

@jreback jreback added this to the 0.15.2 milestone Dec 3, 2014
@jreback
Copy link
Contributor

jreback commented Dec 3, 2014

@cswarth can you update to the comments?

@cswarth
Copy link
Contributor Author

cswarth commented Dec 3, 2014

not sure what you need for in an update - I was just getting back to this when you mail came in. I'll modify other doc sections on .iloc as requested. Do you think it worth mentioning in close proximity that boolean array indexers should span the full axis? Personally prefer to document what is, not what might be.

@jreback
Copy link
Contributor

jreback commented Dec 3, 2014

@cswarth their are 2 mentions of the iloc description (one at the very top and one where you modified). Need them both to be the same. Nothing additional is necessary w.r.t. what you wrote.

@jreback
Copy link
Contributor

jreback commented Dec 4, 2014

merged via 7be0236

thanks!

@jreback jreback closed this Dec 4, 2014
@jreback jreback mentioned this pull request Dec 4, 2014
Closed
@cswarth cswarth deleted the docfix branch December 4, 2014 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Docs Indexing Related to indexing on series/frames, not to indexes themselves

Projects

None yet

Milestone

0.15.2

Development

Successfully merging this pull request may close these issues.

Documentation for .iloc is misleadingly incomplete

2 participants

@cswarth @jreback