Skip to content

Conversation

sinhrks
Copy link
Member

@sinhrks sinhrks commented Feb 7, 2015

Closes #5662. Refactored a little.

Made examples to confirm 1st and 2nd row's yaxis are identical.

import pandas as pd
import numpy as np
df = pd.DataFrame(np.random.randn(100, 3))
df[0] = df[1]
pd.tools.plotting.scatter_matrix(df)

figure_1

df[1] = df[1] / 3 - 2
df[0] = df[1]
pd.tools.plotting.scatter_matrix(df)

figure_2

@jorisvandenbossche jorisvandenbossche added this to the 0.16.0 milestone Feb 8, 2015
@jreback jreback modified the milestones: 0.16.0, Next Major Release Mar 3, 2015
@jorisvandenbossche
Copy link
Member

@sinhrks is there actually anything that prevents this from being merged?
cc @TomAugspurger

@sinhrks
Copy link
Member Author

sinhrks commented Mar 31, 2015

No, I think this is ready for review. Because it is categorized as a bug fix, is it possible to include it in 0.16.1 (not next major release)?

I'll rebase this later to fix the release note.

@jorisvandenbossche jorisvandenbossche modified the milestones: 0.16.1, Next Major Release Mar 31, 2015
@TomAugspurger
Copy link
Contributor

Thanks. Ping me when the rebase is done and I'll get it merged.

On Mar 30, 2015, at 22:18, Sinhrks [email protected] wrote:

No, I think this is ready for review. Because it is categorized as a bug fix, is it possible to include it in 0.16.1 (not next major release)?

I'll rebase to in this later to fix the release note.


Reply to this email directly or view it on GitHub.

@sinhrks
Copy link
Member Author

sinhrks commented Mar 31, 2015

@TomAugspurger Rebased, and now green.

TomAugspurger pushed a commit that referenced this pull request Mar 31, 2015
BUG: scatter_matrix draws incorrect axis
@TomAugspurger TomAugspurger merged commit cb8c130 into pandas-dev:master Mar 31, 2015
@TomAugspurger
Copy link
Contributor

OK, thanks!

@sinhrks sinhrks deleted the sm_axis branch April 1, 2015 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unexpected axis ticks in tools.plotting.scatter_matrix

4 participants