Skip to content

BUG: support TimedeltaIndex serialization in fixed stores (GH9635) #9662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 19 commits into from
Closed

BUG: support TimedeltaIndex serialization in fixed stores (GH9635) #9662

wants to merge 19 commits into from

Conversation

JonasAbernot
Copy link
Contributor

closes #9635

Small change to fix issue 9635. I'm a beginner contributor, feel free to crush it out.

@TomAugspurger
Copy link
Contributor

I updated your comment with "closes" and a link to the issue. Now Github will automatically close that issue when we merge this.

@TomAugspurger
Copy link
Contributor

A couple more things.

  1. Could you add a test for this? Something that fails on master (without your patch), and works on your branch
  2. Add a release note in doc/source/whatsnew/v0.16.1 with a sentence describing the bug.

Actually, that whatsnew file may not exist yet. Once we start merging pull requests for .16.1 it will be there.

JonasAbernot and others added 2 commits March 16, 2015 14:23
@JonasAbernot
add test for issue 9635
90271fa
@jreback
Merge pull request #9182 from bjonen/fix_series
e106df7 
FIX: Fix problems with Series text representation.
jreback
jreback reviewed Mar 17, 2015
View reviewed changes
pandas/io/tests/test_pytables.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the issue number as a comment here.

@jreback jreback added Bug Dtype Conversions Unexpected or buggy dtype conversions IO HDF5 read_hdf, HDFStore Timedelta Timedelta data type labels Mar 17, 2015
@jreback jreback added this to the 0.16.1 milestone Mar 17, 2015
@jreback
Copy link
Contributor

jreback commented Mar 17, 2015

@JonasAbernot pretty good!

will need a release note (wait till the end of the week after I push the file up after we release 0.16.0)

@jreback
Merge pull request #9665 from mortada/clean_up
482643a 
DOC: grammar fixes, add conda install to README
@jreback jreback changed the title fix issue 9635 BUG: support TimedeltaIndex serialization in fixed stores (GH9635) Mar 17, 2015
@JonasAbernot
Merge branch 'to_fix_issue_9635' of github.com:JonasAbernot/pandas in…
4fd6998 
…to to_fix_issue_9635

Conflicts:
	pandas/io/tests/test_pytables.py
@JonasAbernot
Copy link
Contributor Author

Woups, this time I may need your help. Are all these commits normal ? I tried the

git fetch upstream
git rebase upstream/master

from the wiki.
Should I come back ? And how ?

@TomAugspurger
Copy link
Contributor

This is the one you want.

The --interactive should open up a window in your editor. Here's some more info. Basically you'll squash them all down to the first commit. Ping us in chat if you have any trouble.

@JonasAbernot JonasAbernot deleted the to_fix_issue_9635 branch March 17, 2015 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Bug Dtype Conversions Unexpected or buggy dtype conversions IO HDF5 read_hdf, HDFStore Timedelta Timedelta data type

Projects

None yet

Milestone

0.16.1

Development

Successfully merging this pull request may close these issues.

Hdf5/PyTables support for TimedeltaIndex

6 participants

@JonasAbernot @TomAugspurger @jreback @sinhrks @bjonen @jorisvandenbossche