Skip to content

Conversation

sinhrks
Copy link
Member

@sinhrks sinhrks commented Apr 23, 2015

Derived from #9862. Added check_names kw to followings testing functions:

  • assert_index_equal (default=True).
  • assert_series_equal (default=True). Maybe the same option can be used to check Series.name in the future, otherwise it may better to choose separate name such as check_index_name.
  • assert_panelnd_equal (default=False). We have to check following ToDo to specify default=True.
  • https://github.com/pydata/pandas/blob/master/pandas/util/testing.py#L771
  • assert_frame_equal is untouched as it already has the kw. Not refactored the logic because it has a path which doesn't use assert_index_equal internally.

Looked through test cases which have to be check_names=False, and added name check tests.

@sinhrks sinhrks added Testing pandas testing functions or related to the test suite Indexing Related to indexing on series/frames, not to indexes themselves labels Apr 24, 2015
@jreback jreback added this to the 0.16.1 milestone Apr 24, 2015
jreback added a commit that referenced this pull request Apr 28, 2015
@jreback jreback merged commit eb64190 into pandas-dev:master Apr 28, 2015
@jreback
Copy link
Contributor

jreback commented Apr 28, 2015

@sinhrks thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Indexing Related to indexing on series/frames, not to indexes themselves Testing pandas testing functions or related to the test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants