fix: don't run Distinct() over the directions and correct the length (AscensionGameDev#2020)

Author: pandinocoder

Intersect (Core)/Configuration/ClientConfiguration.cs

@@ -3,6 +3,7 @@
 
 using Intersect.Enums;
 using Intersect.Logging;
+using Intersect.Utilities;
 using Newtonsoft.Json;
 
 namespace Intersect.Configuration
@@ -42,7 +43,7 @@ public static ClientConfiguration LoadAndSave(string? filePath = default)
 
         public static List<DisplayDirection> DEFAULT_ENTITY_BAR_DIRECTIONS =>
             Enumerable
-                .Range(0, Enum.GetValues<Vital>().Length)
+                .Range(0, 1 + Enum.GetValues<Vital>().Length)
                 .Select(_ => DisplayDirection.StartToEnd)
                 .ToList();
 
@@ -60,7 +61,7 @@ public static ClientConfiguration LoadAndSave(string? filePath = default)
 
         public const bool DEFAULT_TYPEWRITER_ENABLED = true;
 
-        public static List<char> DEFAULT_TYPEWRITER_FULL_STOP_CHARACTERS => new List<char>()
+        public static List<char> DEFAULT_TYPEWRITER_FULL_STOP_CHARACTERS => new()
         {
             '.',
             '!',
@@ -72,7 +73,7 @@ public static ClientConfiguration LoadAndSave(string? filePath = default)
 
         public const long DEFAULT_TYPEWRITER_PART_DELAY = 6;
 
-        public static List<char> DEFAULT_TYPEWRITER_PAUSE_CHARACTERS => new List<char>()
+        public static List<char> DEFAULT_TYPEWRITER_PAUSE_CHARACTERS => new()
         {
             ',',
             ';',
@@ -85,7 +86,7 @@ public static ClientConfiguration LoadAndSave(string? filePath = default)
 
         public const int DEFAULT_TYPEWRITER_SOUND_FREQUENCY = 5;
 
-        public static List<string> DEFAULT_TYPEWRITER_SOUNDS => new List<string>()
+        public static List<string> DEFAULT_TYPEWRITER_SOUNDS => new()
         {
             "octave-beep-tapped.wav"
         };
@@ -94,19 +95,16 @@ public static ClientConfiguration LoadAndSave(string? filePath = default)
 
         #region Static Properties and Methods
 
-        public static ClientConfiguration Instance { get; } = new ClientConfiguration();
+        public static ClientConfiguration Instance { get; } = new();
 
         public void Validate()
         {
-            ChatLines = Math.Min(Math.Max(ChatLines, 10), 500);
+            ChatLines = MathHelper.Clamp(ChatLines, 10, 500);
 
-            var entityBarDirections = EntityBarDirections.Distinct()?.ToList();
             EntityBarDirections = DEFAULT_ENTITY_BAR_DIRECTIONS.Select(
-                (direction, index) =>
-                    (entityBarDirections?.Count ?? 0) > index
-                        ? entityBarDirections[index]
-                        : direction
-            ).ToList();
+                    (direction, index) => EntityBarDirections.Count > index ? EntityBarDirections[index] : direction
+                )
+                .ToList();
 
             GameFont = string.IsNullOrWhiteSpace(GameFont) ? DEFAULT_FONT : GameFont.Trim();
             Host = string.IsNullOrWhiteSpace(Host) ? DEFAULT_HOST : Host.Trim();
@@ -176,7 +174,7 @@ public void Validate()
         /// Static background Example: { "background.png" },
         /// Animated background Example: { "background_0.png", "background_1.png", "background_2.png" },
         /// </summary>
-        public List<string> MenuBackground { get; set; } = new List<string> { "background.png" };
+        public List<string> MenuBackground { get; set; } = new() { "background.png" };
 
         /// <summary>
         /// Sets the display mode of the main menu's background.
@@ -191,7 +189,7 @@ public void Validate()
         /// <summary>
         /// A list from which introductory images are drawn when the game client is launched.
         /// </summary>
-        public List<string> IntroImages { get; set; } = new List<string>();
+        public List<string> IntroImages { get; set; } = new();
 
         /// <summary>
         /// The address for the update manifest file generated by the editor.