Conversation
Member
Author
|
If this is merged, then we could create releases with Dockerfiles for each pandoc release. |
tarleb
force-pushed
the
dockerfiles-from-templates
branch
4 times, most recently
from
b5ac659 to
ddddc40
Compare
tarleb
force-pushed
the
dockerfiles-from-templates
branch
2 times, most recently
from
8950d61 to
612744e
Compare
tarleb
force-pushed
the
dockerfiles-from-templates
branch
from
612744e to
b520f71
Compare
Member
Author
|
There's still room for improvements, but it seems to be working well enough, so I'm merging it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dockerfiles are created explicitly from a template, instead using a highly configurable Dockerfile. The complexity is therefore shifted into the template and into the scripts used to generate the version-specific Dockerfiles.
Almost all configurations have been merged into a single file,
config.yaml. That file now controls the set of supported pandoc releases, the base images, and parameters for the addon images (e.g, latex and typst). Generate Dockerfiles by running./pandock.lua generate <PANDOC_VERSION>. This will also create adocker-bake.jsonfile, to make reproducible builds even easier.