Skip to content

Conversation

@Wolf-SO
Copy link
Contributor

@Wolf-SO Wolf-SO commented Mar 12, 2025

@alerque
Copy link
Collaborator

alerque commented Mar 12, 2025

You beat me to the fix by a few minutes (c.f. #288) but I don't think this PR will actually fix the problem. You're changing L282, but the entire table is clobbering itself and L318 probably just resets this (Lua not handling table keys deterministically possibly leading to some failures and some successes). My PR should correctly fix this table mess as well as make this change.

@alerque
Copy link
Collaborator

alerque commented Mar 12, 2025

(And for the record I wouldn't have clobbered your PR on purpose if I'd seen it, I went to work when you posted the issue at which time there was no PR and didn't see this PR until I had posted mine via the CLI.)

@Wolf-SO
Copy link
Contributor Author

Wolf-SO commented Mar 12, 2025

@alerque I see, is there a way to revoke my pull request?

...and, should something be done on the original repo?

@alerque alerque closed this Mar 12, 2025
@Wolf-SO Wolf-SO deleted the patch-2 branch March 12, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong secondary Russian quotation marks

2 participants