-
Notifications
You must be signed in to change notification settings - Fork 38
Fix CI to use correct python versions #463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Well, the CI is fixed at least... |
|
@huard, I believe this is a case where following the SPEC0 is easier. According to SPEC 0, we are allowed to drop support for python 3.9, 3.10 and 3.11. I'd say we keep 3.11, but drop the two others. Instead of fixing the issues. There is also a forgotten scipy call to fix. I don't understand why scipy is installed here, on all builds, but not in the xesmf-feedstock build. Not sure how to make a CI build without it as it is not requested anywhere... |
|
The mask creation code got a lot simpler. It is exercised by the test suite I assume ? |
|
It is in the tests! The last error here is sadly significative. For one case, the spatial averager, returns a wrong result. It happens with the "segmentized" version of the polygon, not with the "raw" one. And it only happens with 3.11 and esmf 8.4. The shapely version is the same in all envs, so my guess is that this comes from ESMpy/ESMF. ESMF 8.4 is the last available version for windows so I don't think we should drop it. I'll look into the issue in more details. @sol1105 Sorry about the delay... |
|
I have not understood the issue, but I have avoided it. When we segmentize the test polygons with exactly I avoided the issue by segmentizing with 0.99 .... @huard I will release yet another patch after merging, I already updated the changelog. |
No description provided.