Conversation
There was a problem hiding this comment.
Pull request overview
This patch release (v2.11.4) includes a critical concurrency bug fix in the worker pool implementation and updates the documentation with new users and a restructured donation section.
- Fixed a race condition in worker retrieval by ensuring the lock is released after the worker's running counter is incremented
- Updated README files to include new organizations (Apache Software Foundation, Coze) and open-source projects using ants
- Restructured the donation section to use a table format with Buy Me a Coffee, Patreon, and Open Collective links
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| ants.go | Fixed race condition by moving lock unlock to after worker.run() call to ensure running counter is accurate before other goroutines can check capacity |
| README.md | Added new organizations and open-source projects to user cases section; restructured donation section with new table layout |
| README_ZH.md | Chinese version of README updates - added same organizations and projects; restructured donation section with new table layout |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #377 +/- ##
==========================================
- Coverage 94.09% 94.03% -0.07%
==========================================
Files 14 14
Lines 966 788 -178
==========================================
- Hits 909 741 -168
+ Misses 46 35 -11
- Partials 11 12 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <tr> | ||
| <td align="center" valign="middle"> | ||
| <a target="_blank" href="https://buymeacoffee.com/panjf2000"> | ||
| <img src="https://res.strikefreedom.top/static_res/logos/bmc_qr.png" width="250" alt="Buy me coffee" /> |
There was a problem hiding this comment.
The alt text is missing the article "a". It should be "Buy me a coffee" to match the English version in README.md and be grammatically correct.
| <img src="https://res.strikefreedom.top/static_res/logos/bmc_qr.png" width="250" alt="Buy me coffee" /> | |
| <img src="https://res.strikefreedom.top/static_res/logos/bmc_qr.png" width="250" alt="Buy me a coffee" /> |
No description provided.