Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the time tracking mechanism in the goroutine pool by converting the now field from atomic.Value to int64 for better performance.
Changes:
- Changed
poolCommon.nowfield type fromatomic.Valuetoint64to store Unix nanoseconds - Updated all time store operations to use
atomic.StoreInt64withtime.Now().UnixNano() - Modified the
nowTime()method to reconstructtime.Timefrom stored nanoseconds usingatomic.LoadInt64
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #379 +/- ##
==========================================
+ Coverage 94.03% 94.54% +0.50%
==========================================
Files 14 14
Lines 788 788
==========================================
+ Hits 741 745 +4
+ Misses 35 32 -3
+ Partials 12 11 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@panjf2000 would love to get this merged if possible! |
Contributor
|
@panjf2000 thank you, I appreciate it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.