pkg/ring/ring_buffer: remove the unused field "bs" #736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panjf2000
added
waiting for response
panjf2000
requested changes
Nov 3, 2025
pkg/buffer/ring/ring_buffer.go
Outdated
| func New(size int) *Buffer { | ||
| if size == 0 { | ||
| return &Buffer{bs: make([][]byte, 2), isEmpty: true} | ||
| return &Buffer{bs: make(isEmpty: true} |
Owner
There was a problem hiding this comment.
This is not even valid Go syntax. Did you run the tests locally before creating the PR?
Contributor
Author
There was a problem hiding this comment.
The test with the ring package was run, and everything was OK.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #736 +/- ##
==========================================
+ Coverage 82.53% 84.11% +1.57%
==========================================
Files 22 22
Lines 2915 2399 -516
==========================================
- Hits 2406 2018 -388
+ Misses 387 259 -128
Partials 122 122
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
panjf2000
changed the title
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove unused fileds bs.
1. Are you opening this pull request for bug-fix, optimization or new feature?
optimization
2. Please describe how these code changes achieve your intention.
unused fields
3. Please link to the relevant issues (if any).
4. Checklist
I am willing to help maintain this change if there are issues with it later.