Conversation
Using generics, allowing to switch transparently between uint8 and uint16 for the fingerprint size. Performance neutral according to benchmarks ~/goworkspace/bin/benchstat ~/master.benchstats ~/generics.benchstats name old time/op new time/op delta Filter_Reset-4 10.0µs ± 0% 9.9µs ± 0% ~ (p=1.000 n=1+1) Filter_Insert-4 18.2µs ± 0% 18.0µs ± 0% ~ (p=1.000 n=1+1) Filter_Lookup-4 1.52µs ± 0% 1.51µs ± 0% ~ (p=1.000 n=1+1)
Instead of using multiple methods for instantiating a filter for a chosen precision.
There is no asymptotic advantage to try both idx & alt idx for an item to insert. Rather just let cuckoo kickout do it's thing.
Avoids some unnecessary ifs in the implementation.
By seeding random source.
Previously, items only moved to the alternative index on cuckoo inserts.
Plus a tiny rename.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented by using different types for fingerprints via generics.