Add DisallowRenameFunctionSniff for rename() restrictions#18
Merged
jazzsequence merged 12 commits intomainfrom Jul 18, 2025
Merged
Add DisallowRenameFunctionSniff for rename() restrictions#18jazzsequence merged 12 commits intomainfrom
DisallowRenameFunctionSniff for rename() restrictions#18jazzsequence merged 12 commits intomainfrom
Conversation
wp warns, we error
DisallowRenameFunctionSniff for rename() restrictions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new sniff to disallow the use of the
rename()function due to file system restrictions on Pantheon. Update coding standards to include this sniff, remove deprecated checks, and add tests to ensure compliance. Implement a testing script and configure automated testing on push events.NB: WordPress standards already warn against the
renamefunction. We're erroring on the standard because it's a hard block on the platform.fixes #15