Skip to content

Fixes missing script error #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jazzsequence merged 2 commits into from
May 6, 2025
Merged

Fixes missing script error #183

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a8ac6f
update php versions
jazzsequence Apr 28, 2025
beec511
fix typo in maybe-create-symlinks
jazzsequence Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions upstream-configuration/scripts/ComposerScripts.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ public static function applyComposerJsonUpdates(Event $event)
}
}

$maybe_add_symlinks = '@maybe-add-symlinks';
$maybe_add_symlinks = '@maybe-create-symlinks';
// Check if @maybe-add-symlinks is already in post-update-cmd. If not, add it.
if (!in_array($maybe_add_symlinks, $composerJson['scripts']['post-update-cmd'])) {
$io->write("<info>Adding $maybe_add_symlinks to post-update-cmd hook</info>");
Expand Down Expand Up @@ -206,14 +206,16 @@ private static function bestPhpPatchVersion($pantheonPhpVersion)
{
// Integrated Composer requires PHP 7.1 at a minimum.
$patchVersions = [
'8.2' => '8.2.0',
'8.1' => '8.1.13',
'8.0' => '8.0.26',
'8.3' => '8.3.14',
'8.2' => '8.2.26',
'8.1' => '8.1.31',
// EOL final patch version below this line.
'8.0' => '8.0.30',
'7.4' => '7.4.33',
'7.3' => '7.3.33',
'7.2' => '7.2.34',
'7.1' => '7.1.33',
];
];
if (isset($patchVersions[$pantheonPhpVersion])) {
return $patchVersions[$pantheonPhpVersion];
}
Expand Down
Loading