Skip to content

Conversation

@AnaisPantheor
Copy link

Allows php version 8.4

@github-actions
Copy link

Hi from your friendly robot! 🤖 It looks like there might be commits to both release and non-release files in this PR. Please review and remove any commits that don't belong.

1 similar comment
@github-actions
Copy link

Hi from your friendly robot! 🤖 It looks like there might be commits to both release and non-release files in this PR. Please review and remove any commits that don't belong.

@jazzsequence
Copy link
Contributor

jazzsequence commented May 29, 2025

Hi @AnaisPantheor 👋
Because of how the upstream deploy workflow works, commits that include "release" (e.g. files that are shipped to customers) and "non-release" (e.g. files that are only for CI purposes) files will be excluded on deploy. This means that the change to ComposerScripts.php will get lost, which is why many of the tests are failing. (I've loosened the failure to be a warning and a comment in the PR rather than a hard failure in #186 here).

Before this PR can be merged, that specific change needs to be reverted and pushed in a separate commit. See also the readme note on "release" and "non-release" commits. When #186 is merged, the comment will be updated to remind you to merge via merge commit rather than squash and merge for this PR.

@scottbuscemi scottbuscemi changed the title [SITE-2249] Allows php 8.4 [SITE-1973] [SITE-2249] Allows php 8.4 Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants