Feedback wanted: Integrate FAIR into WordPress (Composer Managed)#188
Open
jazzsequence wants to merge 8 commits intopantheon-systems:defaultfrom
Open
Feedback wanted: Integrate FAIR into WordPress (Composer Managed)#188jazzsequence wants to merge 8 commits intopantheon-systems:defaultfrom
jazzsequence wants to merge 8 commits intopantheon-systems:defaultfrom
Conversation
Contributor
Author
|
One thought I have about this that is possibly a counter-argument to inclusion is the fact that FAIR is largely a stand-in replacement for WordPress automatic/internal updates and install mechanisms. With Composer-based sites, we're getting updates from Composer (and, likely WPackagist in front of WordPress.org). Unless/until there is a stand-in integration/replacement within FAIR that steps in front of api.wordpress.org after wpackagist.org, we'll only get the limited value of the extra API stuff (internal solutions for A8c-based APIs/properties) that the FAIR plugin adds, but won't benefit from the protocol at all, really. |
Contributor
Author
|
See https://github.com/orgs/fairpm/discussions/41 related to the above comment ☝️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows on from pantheon-systems/WordPress#419. Discussion about whether and why to integrate FAIR into WordPress upstreams broadly should use that ticket for discussion. The implementation is largely the same as that PR.
Considerations
composer.jsonfile. There's a (strong) argument here to wait until it's added to Packagist.org before this PR is merged.composer.jsonfile, but doing so (at least in the current implementation) can cause merge conflicts and/or rewrite the sitecomposer.jsonfile on existing WPCM sites. The safest way of applying this update is doing so manually (Note: current docs do not show how to do this with WPCM), which creates a barrier to entry.Route feedback and discussion to pantheon-systems/WordPress#419 and link to this issue to show that you are referring to the Composer Managed implementation of WordPress.