Allow setting project name#486
Merged
wisechengyi merged 1 commit intopantsbuild:masterfrom Feb 4, 2020
mzarnowski:allow-setting-project-name
Merged
Allow setting project name#486wisechengyi merged 1 commit intopantsbuild:masterfrom mzarnowski:allow-setting-project-name
wisechengyi merged 1 commit intopantsbuild:masterfrom
mzarnowski:allow-setting-project-name
Conversation
Contributor
Author
|
The four failures: Are exactly the same as those in #483 (https://travis-ci.com/pantsbuild/intellij-pants-plugin/jobs/279379516) so I believe they are not related. |
wisechengyi
approved these changes
Feb 4, 2020
Collaborator
wisechengyi
left a comment
There was a problem hiding this comment.
This is great, thanks @marek1840!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, project name was derived from the targets used for importing it. Now, user can specify it when importing.
The import window looks as follows

And the resulting structure is:

The project view:

The name field is being automatically populated if and only if it was not changed by the user.

The strategy for generation of project name tries to mimic current approach (with a change of prepending the build root directory name). Since I don't have much experience with using the pants build tool, I could use some suggestions on how those automatically generated names could look like to actually useful.