switch to "protoc-gen-grpc-python-prebuilt" for the grpc-python-plugin#23019
switch to "protoc-gen-grpc-python-prebuilt" for the grpc-python-plugin#23019cburroughs merged 4 commits intopantsbuild:mainfrom
Conversation
|
"works on my machine", but nhurden/protoc-gen-grpc-python-prebuilt#30 |
|
cc @joel-eq since you were looking at this. |
|
Question: Would this be a better idea to vendor, like was done previously? But this time put automation around notifying us when it's out of date? So like, continue to use the binaries.pantsbuild.org or Github Releases (preferably) in a repo? |
|
Well previously we did this: aws --profile=pants s3 cp --acl public-read (Which was a great step because it worked and unblocked users!) So I think automation of building the binaries is a step forward. I'd rather GitHub release to something that incurs costs to the nonprofit. I'm fine with forking Given the current once-every 5(?) years update rate, this wouldn't be the first thing I'd try to automate version notifications around. |
|
Progress on glibc, but: actions/partner-runner-images#157 |
|
Thanks for the contribution. We've just branched for 2.31.x, so merging this pull request now will come out in 2.32.x, please move the release notes updates to docs/notes/2.32.x.md if that's appropriate. |
5325bd6 to
6a191ff
Compare
|
And the latest release with nhurden/protoc-gen-grpc-python-prebuilt#38 is green; yeah! |
|
(oh @sureshjoshi had already commented; anyone welcome to review!) |
First of all, why does this exist at all? See grpc/grpc#26125 Because of that way back in pantsbuild#10927 we built the plugin and uploaded it to binaries.pantsbuild.org. In the intervening time the original upstream issue is unresolved, but someone did the work to put together multi-arch CI at https://github.com/nhurden/protoc-gen-grpc-python-prebuilt This gives us a more recent version and fills in the missing macos arm64 support. We could fork and host in the pantsbuild org on GitHub, but given the rate of change to grpc-python-plugin I don't think that is warranted right now. This removes one of the last things the project pays to serve from binaries.pantsbuild.org
6a191ff to
f37dc40
Compare
First of all, why does this exist at all? See
grpc/grpc#26125
Because of that way back in #10927 we built the plugin and uploaded it to binaries.pantsbuild.org. In the intervening time the original upstream issue is unresolved, but someone did the work to put together multi-arch CI at
https://github.com/nhurden/protoc-gen-grpc-python-prebuilt This gives us a more recent version and fills in the missing macos arm64 support.
We could fork and host in the pantsbuild org on GitHub, but given the rate of change to grpc-python-plugin I don't think that is warranted right now.
This removes one of the last things the project pays to serve from binaries.pantsbuild.org