Skip to content

Add some default module mappings#23101

Merged
benjyw merged 1 commit intopantsbuild:mainfrom
benjyw:add_default_module_mappings
Feb 18, 2026
Merged

Add some default module mappings#23101
benjyw merged 1 commit intopantsbuild:mainfrom
benjyw:add_default_module_mappings

Conversation

@benjyw
Copy link
Contributor

@benjyw benjyw commented Feb 13, 2026

No description provided.

@benjyw benjyw added the release-notes:not-required [CI] PR doesn't require mention in release notes label Feb 13, 2026
@benjyw benjyw requested review from cburroughs and tdyas February 13, 2026 23:23
@benjyw
Copy link
Contributor Author

benjyw commented Feb 13, 2026

These came up while hacking on a real-world Django repo.

Copy link
Contributor

@cburroughs cburroughs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; all optional end of the day stream of thought tangents below.

Since we have been talking about LLMs a fair amount recently, as an experiment I told one this:

""" We are going to review #23101 For each module mapping (pypi name --> import name),
find the project on mypy, download the metadata for the altest version, and confirm the mapping in the PR""" (including my bad spelling and ambiguity around "metadata")

It then floundered around with PyPI/pip/wheels and spit out:

  | PyPI Package            | Import Name        | Verified                       |
  |-------------------------|--------------------|--------------------------------|
  | amplitude-analytics     | amplitude          | ✓ (top_level.txt)              |
  | bandwidth-sdk           | bandwidth          | ✓ (PyPI docs)                  |
  | drf-openapi-tester      | openapi_tester     | ✓ (PyPI docs)                  |
  | django-extensions       | django_extensions  | ✓ (INSTALLED_APPS)             |
  | django-fernet-fields-v2 | fernet_fields      | ✓ (top_level.txt)              |
  | django-money            | djmoney            | ✓ (PyPI docs + INSTALLED_APPS) |
  | django-pylibmc          | django_pylibmc     | ✓ (backend path)               |
  | django-user-agents      | django_user_agents | ✓ (INSTALLED_APPS)             |
  | mysqlclient             | MySQLdb            | ✓ (PyPI docs)                  |
  | pyicu                   | icu                | ✓ (PyPI docs)                  |
  | social-auth-app-django  | social_django      | ✓ (top_level.txt)              |
  | social-auth-core        | social_core        | ✓ (top_level.txt)              |
  | unittest-xml-reporting  | xmlrunner          | ✓ (PyPI docs)                  |

Is this perfect or 100% confident or better than what benjw did to begin with? Nope, but I'll be honest and say I don't usually verify every one of these line by line myself. One of the things I personally am trying to figure out is how LLMs can be used to improve review quality and increase rigor as opposed to merely "velocity".

@benjyw benjyw merged commit 99b47f0 into pantsbuild:main Feb 18, 2026
25 checks passed
@benjyw benjyw deleted the add_default_module_mappings branch February 18, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes:not-required [CI] PR doesn't require mention in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments